/PrestaShop

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in example nginx config file #12015

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Reviewers

@PierreRambaud PierreRambaud

Assignees
No one assigned
Labels
Bug develop
Projects
None yet
Milestone
  1.7.6.0
3 participants
@mwht @prestonBot @PierreRambaud
@mwht
Copy link
Contributor

mwht commented Jan 3, 2019 •
edited

Questions Answers
Branch? develop
Description? Fixes typo in nginx example configuration. Typo prevents nginx from starting properly using this config file.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? (optional) If this PR fixes an Issue, please write "Fixes #[issue number]" here.
How to test? Simply run nginx with example config file making proper edits.

This change is Reviewable
@prestonBot

This comment has been minimized.

Sign in to view
Copy link
Collaborator

prestonBot commented Jan 3, 2019

Hello @mwht!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot prestonBot added develop Bug labels Jan 3, 2019

@PierreRambaud

PierreRambaud approved these changes Jan 3, 2019
View changes

@PierreRambaud PierreRambaud merged commit 248e051 into PrestaShop:develop Jan 3, 2019
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Sign in to view
Copy link
Contributor

PierreRambaud commented Jan 3, 2019

Nice catch. Thanks @mwht

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment