New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak token implementation #12017

Merged
merged 1 commit into from Jan 22, 2019

Conversation

@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 3, 2019

Questions Answers
Branch? develop
Description? Display error message when trying to use an old reset token.
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11751
How to test? You should not be able to see the change password form with an old reset_token. See fixed ticket description to see how the bug works. With this PR, the bug should be fixed.

This change is Reviewable

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Jan 10, 2019

@PierreRambaud, I'm working with @TristanLDD on improving error notifications, we'll have a look at it together and I'll get back to you. @TristanLDD, let me know when we can check this PR, thank you.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 10, 2019

@LouiseBonnard Don't understand why PrestonBot add the Waiting for wording because I don't add wordings, just move code position :D

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Jan 10, 2019

Yep, but it's the right time (as the content is editable) to think a bit about how we can improve the wording - if needed. :-)

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 10, 2019

@LouiseBonnard So keep the Waiting for Wording, I will change everything you want, only for you (and @TristanLDD) 😍 !

@marionf marionf self-assigned this Jan 11, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 14, 2019

@marionf marionf removed their assignment Jan 14, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 21, 2019

Still waiting? any news here?

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Jan 22, 2019

@PierreRambaud, it is alright as is, don't wait too long - we will work on another issue to draw guidelines and harmonize PrestaShop ton of voice: #12235. :-)

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 22, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit e74b715 into PrestaShop:develop Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/11751 branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment