New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony Cache Clear in ModuleManager instead of deprecated Cache … #12022

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@matks
Copy link
Contributor

matks commented Jan 4, 2019

This PR is the result of a discussion with @PierreRambaud and @jolelievre

Questions Answers
Branch? develop
Description? Use Symfony Cache Clear in ModuleManager as CacheClearer is deprecated
Type? refacto
Category? CO
BC breaks? yes ⚠️
Deprecations? no
Fixed ticket?
How to test? Module Manager usage should be unchanged. Every module action (install, enable, disable, configure, reset ...) should still work in the BO.

This change is Reviewable

@jolelievre
Copy link
Contributor

jolelievre left a comment

great @matks
I feel lighter now ^^

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 4, 2019

But if we change the constructor, it is a BC Break :trollface:

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 4, 2019

@marionf marionf self-assigned this Jan 7, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 7, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 9931d8b into PrestaShop:develop Jan 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 7, 2019

Thank you @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment