New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERP : Avoid mutating a prop directly + fix url encode #12052

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 7, 2019

Questions Answers
Branch? develop
Description? Avoid mutating a prop directly since the value will be overwritten whenever the parent component re-renders.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Product -> SEO -> Change url

Before when running npm run watch:
selection_053


This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 7, 2019

@PierreRambaud PierreRambaud requested a review from Quetzacoalt91 Jan 7, 2019

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 7, 2019

Hmm, it seems the description is not truncated anymore if too long, doesn't it?

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/serp branch from 88ba4f5 to 2f22b08 Jan 7, 2019

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/serp branch from 2f22b08 to 132ea08 Jan 8, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 8, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 47a0a56 into PrestaShop:develop Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/serp branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment