New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate legacy unit test for Hashing #12054

Merged
merged 2 commits into from Jan 8, 2019

Conversation

Projects
None yet
3 participants
@matks
Copy link
Contributor

matks commented Jan 7, 2019

Questions Answers
Branch? develop
Description? Migrate legacy test for class Hashing. New test does not need to be run on separate process.
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Travis should be green

This change is Reviewable

@matks matks changed the title Migrate legacy tests for Hashing Migrate legacy unit test for Hashing Jan 7, 2019

$hashing = new Hashing();
$salt = '2349123849231-4123';
$this->assertTrue($hashing->checkHash("123", md5($salt . "123"), $salt));

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 8, 2019

Contributor

use single quote please ❤️

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 8, 2019

@PierreRambaud requested changes have been applied in 0209f3b

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 8, 2019

@PierreRambaud PierreRambaud merged commit 8e4fcb6 into PrestaShop:develop Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 8, 2019

Thanks @matks 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment