New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable PHP CS Fixer on tests folder #12060

Merged
merged 1 commit into from Jan 8, 2019

Conversation

Projects
None yet
4 participants
@matks
Copy link
Contributor

matks commented Jan 8, 2019

Following @PierreRambaud suggestion

Questions Answers
Branch? develop
Description? Enable PHP CS Fixer for tests folder in order to keep our test code clean and smooth
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Travis should be green

This change is Reviewable

@Quetzacoalt91 Quetzacoalt91 merged commit ed9e325 into PrestaShop:develop Jan 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 8, 2019

No need of QA review on this one.

Thank you @matks

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 8, 2019

@matks matks deleted the matks:enable-cs-fixer-on-test-folder branch Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment