Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd some fixes to the campaign full #12067
Conversation
prestonBot
added
develop
Refactoring
labels
Jan 8, 2019
khouloudbelguith
added
the
TE
label
Jan 8, 2019
PierreRambaud
reviewed
Jan 8, 2019
| @@ -0,0 +1,3 @@ | |||
| module.exports = Object.assign( | |||
| require('./performence') | |||
This comment has been minimized.
This comment has been minimized.
PierreRambaud
reviewed
Jan 8, 2019
| @@ -0,0 +1,7 @@ | |||
| module.exports = { | |||
| Performence: { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
YosraAk
force-pushed the
YosraAk:fix_full_campaign
branch
from
6375af4
to
9388e2f
Jan 8, 2019
PierreRambaud
reviewed
Jan 8, 2019
| .then(() => { | ||
| if (global.ps_mode_dev) { | ||
| if (global.ps_mode_dev && global.isVisible) { |
This comment has been minimized.
This comment has been minimized.
PierreRambaud
Jan 8, 2019
Contributor
You maybe need to create an helper to remove this duplicate call. Like client.waitForSymfonyToolbar(AddProductPage)
and this function can contain the check about ps_mode_dev and isVisible and the client.waitForExsistAndClick :)
YosraAk
force-pushed the
YosraAk:fix_full_campaign
branch
3 times, most recently
from
ef2df5b
to
6ec71e7
Jan 9, 2019
YosraAk
force-pushed the
YosraAk:fix_full_campaign
branch
from
6ec71e7
to
7890170
Jan 9, 2019
mbadrani
merged commit 0145bd1
into
PrestaShop:develop
Jan 10, 2019
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
mbadrani
added this to the 1.7.6.0 milestone
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
YosraAk commentedJan 8, 2019
•
edited by eternoendless
This change is