New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some fixes to the campaign full #12067

Merged
merged 1 commit into from Jan 10, 2019

Conversation

Projects
None yet
5 participants
@YosraAk
Copy link
Contributor

YosraAk commented Jan 8, 2019

Questions Answers
Branch? develop
Description? Add some fixes to the campaign full
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? /

This change is Reviewable

@@ -0,0 +1,3 @@
module.exports = Object.assign(
require('./performence')

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 8, 2019

Contributor

performance*

@@ -0,0 +1,7 @@
module.exports = {
Performence: {

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 8, 2019

Contributor

Performance*

This comment has been minimized.

@YosraAk

YosraAk Jan 8, 2019

Author Contributor

Thanks! it was a typo error 😅

@YosraAk YosraAk force-pushed the YosraAk:fix_full_campaign branch from 6375af4 to 9388e2f Jan 8, 2019

.then(() => {
if (global.ps_mode_dev) {
if (global.ps_mode_dev && global.isVisible) {

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 8, 2019

Contributor

You maybe need to create an helper to remove this duplicate call. Like client.waitForSymfonyToolbar(AddProductPage)
and this function can contain the check about ps_mode_dev and isVisible and the client.waitForExsistAndClick :)

@YosraAk YosraAk force-pushed the YosraAk:fix_full_campaign branch 3 times, most recently from ef2df5b to 6ec71e7 Jan 9, 2019

@YosraAk YosraAk force-pushed the YosraAk:fix_full_campaign branch from 6ec71e7 to 7890170 Jan 9, 2019

@mbadrani
Copy link
Contributor

mbadrani left a comment

PR so anticipated

@mbadrani mbadrani merged commit 0145bd1 into PrestaShop:develop Jan 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mbadrani mbadrani added this to the 1.7.6.0 milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment