New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto PreferencesController to use annotations #12074

Merged
merged 2 commits into from Jan 22, 2019

Conversation

@matks
Copy link
Contributor

matks commented Jan 8, 2019

Questions Answers
Branch? develop
Description? Refactor Controller to use latest conventions about annotations and update access rules.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Symfony page "Configure > Shop Parameters > General" should behave like before. Access rules have been updated: you need READ rights to display the page and CREATE or UPDATE or DELETE rights to modify it.

This change is Reviewable

@matks matks force-pushed the matks:refacto-PreferencesController branch from 602cff9 to 3f0d5d1 Jan 8, 2019

@matks matks force-pushed the matks:refacto-PreferencesController branch from 3f0d5d1 to fd2627e Jan 9, 2019

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 9, 2019

Requested changes have been applied and commit ammended

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Jan 15, 2019

@ntiepresta ntiepresta self-assigned this Jan 17, 2019

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 17, 2019

@matks error 500 on import page
image

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 17, 2019

Hey @mbadrani, you need to test "Configure > Shop Parameters > General" only here, and with / without access rules :)

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 17, 2019

@matks need rebase to fix the import page (error 500)

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 17, 2019

I know @PierreRambaud but after the pr itself I always test regressions around, Mat confirmed me that need a rebase to avoid false flags in my tests

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 19, 2019

Dismissed QA review as PR has been updated

@mbadrani mbadrani self-assigned this Jan 21, 2019

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 22, 2019

@PierreRambaud PierreRambaud merged commit eca4b7c into PrestaShop:develop Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 22, 2019

Thanks @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment