New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OrderPreferencesController to use annotations #12094

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
6 participants
@matks
Copy link
Contributor

matks commented Jan 9, 2019

Questions Answers
Branch? develop
Description? Refactor Controller to use latest conventions about annotations. Also protect page: now in order to see it you need READ rights;
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Page "Configure > Shop Parameters > Order Settings" should behave like before. However especially access rules are updated: you need READ rights to this page to see it.

This change is Reviewable

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 9, 2019

@eternoendless @PierreRambaud I have implemented here the rule "if you have WRITE rights, you have automatically READ rights too". Is that OK ?

}
/**
* Handle order settings form submit.

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Jan 16, 2019

Contributor

why did you remove the PHPDoc? I'm curious :)

This comment has been minimized.

@matks

matks Jan 18, 2019

Author Contributor

Because the controller has only 2 actions: indexAction and processAction. For me, it's obvious that the 1st handles GET calls and the other one handles form submissions, no need to add it in the phpdoc.

It's like

<?php

/**
 * Cat object
 */
class Cat
{
}
@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 19, 2019

PR updated to follow new access rules

@mbadrani mbadrani self-assigned this Jan 21, 2019

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 22, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 22, 2019

@PierreRambaud PierreRambaud merged commit 9808033 into PrestaShop:develop Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 22, 2019

Thanks @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment