New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto PaymentMethodsController to use annotations #12097

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
7 participants
@matks
Copy link
Contributor

matks commented Jan 9, 2019

Questions Answers
Branch? develop
Description? Refactor Controller to use latest conventions about annotations
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Page "Improve > Payment > Payment Methods" access rule is updated: in order to see it, you need "read" access

This change is Reviewable

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Jan 15, 2019

@ntiepresta ntiepresta self-assigned this Jan 17, 2019

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 17, 2019

@matks need rebase to fix the import page (error 500)

@matks matks force-pushed the matks:refacto-PaymentMethodsController branch from 41a6d3f to 5879f80 Jan 19, 2019

@matks matks removed the QA ✔️ label Jan 19, 2019

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 19, 2019

QA review dismissed as PR has changed

@mbadrani mbadrani self-assigned this Jan 21, 2019

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 21, 2019

@PierreRambaud PierreRambaud merged commit 572c284 into PrestaShop:develop Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 22, 2019

Thanks @matks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment