New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad GridFactory service definition #12125

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
4 participants
@matks
Copy link
Contributor

matks commented Jan 11, 2019

Questions Answers
Branch? develop
Description? GridFactory only expects 3 dependencies in its constructor. Service definition gives 4.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? No QA needed, this is a notice fix of configuration.

This change is Reviewable

@matks matks force-pushed the matks:clean-sf-container-grid-factory branch from bd868be to 09167dc Jan 11, 2019

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 11, 2019

@mickaelandrieu I had to rebase, can you re-review (and re-approve 👼 ) ?

@matks matks force-pushed the matks:clean-sf-container-grid-factory branch from 09167dc to 4dc8a5b Jan 11, 2019

@PierreRambaud PierreRambaud merged commit 5f6488f into PrestaShop:develop Jan 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 12, 2019

Thanks @matks

@matks matks deleted the matks:clean-sf-container-grid-factory branch Jan 13, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment