New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Symfony service definitions #12139

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
5 participants
@matks
Copy link
Contributor

matks commented Jan 13, 2019

Questions Answers
Branch? develop
Description? Fix a Symfony service definition and remove too useless ones
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Only thing to test is "nothing broken in the whole app" 🤔 ... I think we can avoid QA team this task here ^^ considering the PR

This change is Reviewable

@matks matks force-pushed the matks:fix-some-sf-services branch from 53baac2 to 346b337 Jan 13, 2019

@matks matks changed the title Fix multiple Symfony service definitions Fix some Symfony service definitions Jan 13, 2019

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 14, 2019

Let the QA team have their say on this PR :)

@marionf marionf self-assigned this Jan 14, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 14, 2019

@marionf marionf removed their assignment Jan 14, 2019

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 14, 2019

QA has talked 😄

@matks matks merged commit d2c860f into PrestaShop:develop Jan 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matks matks deleted the matks:fix-some-sf-services branch Jan 14, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment