New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixtures does not generate thumbnails #12155

Merged
merged 2 commits into from Jan 15, 2019

Conversation

Projects
None yet
5 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 14, 2019

Questions Answers
Branch? develop
Description? Fixtures need to be the last step of the installation. It needs images types which are data created by the installation theme.
Type? bug fix
Category? IN
BC breaks? no
Deprecations? no
How to test? Try an installation and be sure all thumbnails are created.

This change is Reviewable

@PierreRambaud PierreRambaud changed the title Fix fixtures installation Fixtures does not generate thumbnails Jan 14, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels Jan 15, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit f716800 into PrestaShop:develop Jan 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 15, 2019

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/fixtures branch Jan 15, 2019

@rGaillard

This comment has been minimized.

Copy link
Contributor

rGaillard commented Jan 15, 2019

@PierreRambaud some pre-installed modules doesn't need fixtures anymore for their installation?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 15, 2019

@rGaillard If modules need fixtures to be installed, we have a problem since we have an option to disable demo products 😄

@rGaillard

This comment has been minimized.

Copy link
Contributor

rGaillard commented Jan 15, 2019

@PierreRambaud if i remember correctly, some modules are using the default fixtures for their own fixtures installation this is why we had put fixtures installation before few years ago (but i don't remember which ones). But if there is no demo products, the modules doesn't have fixtures ;)

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 15, 2019

If we find a module with errors, we will change the order again 😉 Thanks for info 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment