New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php-cs-fixer to a recent version to be compatible with PHP7.3 #12166

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 15, 2019

Questions Answers
Branch? develop
Description? Update php-cs-fixer to a recent version to be compatible with PHP7.3.
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? Wait for travis.

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 15, 2019

What did you do in this PR? composer update?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 15, 2019

composer update friendsofphp/php-cs-fixer But it update @Symfony rules

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:update/css-fixer branch from e809ee3 to e2d5d37 Jan 15, 2019

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 15, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 7b87a09 into PrestaShop:develop Jan 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:update/css-fixer branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment