New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTL glitches #12196

Merged
merged 4 commits into from Jan 18, 2019

Conversation

Projects
None yet
6 participants
@eternoendless
Copy link
Member

eternoendless commented Jan 17, 2019

Questions Answers
Branch? 1.7.5.x
Description? This PR fixes two glitches in RTL languages. See below for more.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Install an RTL language or set an existing one to RTL. If you already have one, make sure to delete this file beforehand: admin-dev/themes/new-theme/public/theme_rtl.css. Go to a migrated page, eg. Product Catalog.

Fixed issues:

  1. The PrestaShop logo is badly aligned.

    Before:

    screenshot 2019-01-17 at 16 14 17

    After:

    screenshot 2019-01-17 at 16 17 06

  2. Material checkboxes appear rotated when checked

    Before:

    screenshot 2019-01-17 at 16 14 24

    After:

    screenshot 2019-01-17 at 16 17 24


This change is Reviewable

@eternoendless eternoendless added this to the 1.7.5.1 milestone Jan 17, 2019

@ntiepresta ntiepresta self-assigned this Jan 18, 2019

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 18, 2019

@eternoendless if you make installation in RTL (Persian for my case) on the first step of shop installation: the "/theme_rtl.css" file exists and you still have some glitches

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 18, 2019

@eternoendless does your PR includes the very first installation on RTL also?

@ntiepresta

This comment has been minimized.

Copy link

ntiepresta commented Jan 18, 2019

Hello,
After tested this Pr with installation language RTL (Persian for example). The pop-up user profile should displayed correctly.
persan
Best regards,

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 18, 2019

Hi @khouloudbelguith have you seen an issue like this raised before?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Jan 18, 2019

HI @mbadrani,

Yes, it is reported in this ticket: #12138
Thanks!

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 18, 2019

Great! thanks @khouloudbelguith

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 18, 2019

All good @eternoendless next PR will resolve: #12138

@eternoendless

This comment has been minimized.

Copy link
Member Author

eternoendless commented Jan 18, 2019

Thanks guys

@eternoendless eternoendless merged commit 404ba20 into PrestaShop:1.7.5.x Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eternoendless eternoendless deleted the eternoendless:fix-rtl-issues branch Jan 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment