New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumb to the search results page #12211

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
6 participants
@SebBareyre
Copy link
Contributor

SebBareyre commented Jan 18, 2019

Questions Answers
Branch? develop
Description? add the missing breadcrumb function
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Visit search results page and look at the breadcrumb

This change is Reviewable

Add breadcrumb to the search results page
Add the missing breadcrumb function

@PierreRambaud PierreRambaud force-pushed the SebBareyre:patch-42 branch from 523ea79 to a1f7ebe Jan 18, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 18, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 18, 2019

Thanks @SebBareyre for doing a new PR :)

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Jan 18, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit b77d90b into PrestaShop:develop Jan 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Jan 31, 2019

@SebBareyre the link "Search results" in the breadcrumb shouldn't be the same at the URL ?

capture d ecran_944

capture d ecran_945

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment