New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice for docker-compose #12222

Merged
merged 1 commit into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 18, 2019

Questions Answers
Branch? develop
Description? Add a not to tell to do not forget to set the correct permission before running docker-compose up.
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Nothing to test.

This change is Reviewable

README.md Outdated
@@ -56,7 +56,8 @@ Docker will bind your port 8001 to the web server. If you want to use other port
MySQL credentials can also be found and modified in this file if needed.

**Note:** Before auto-installing PrestaShop, this container checks the file *config/settings.inc.php* does not exist on startup.
If you expect the container to (re)install your shop, remove this file if it exists.
If you expect the container to (re)install your shop, remove this file if it exists. And do not forget to check that your directory
is owned by `www-data:www-data`.

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Jan 19, 2019

Member

We can improve this notice. We don't understand you're talking about the user in the container and people don't always have this user locally.

We could advise to "make sure the container user www-data as write access to the whole workspace".

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 21, 2019

Author Contributor

Done :) Thanks

@prestonBot prestonBot added the develop label Jan 19, 2019

Add notice for docker-compose
Add a not to tell to do not forget to set the correct permission
before running docker-compose up.

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:docker-compose-permission branch from 54311c7 to f6f63bf Jan 21, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 7fd69c7 into PrestaShop:develop Jan 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 21, 2019

@PierreRambaud PierreRambaud deleted the PierreRambaud:docker-compose-permission branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment