New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a json check when running report combine #12225

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
3 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 19, 2019

Questions Answers
Branch? develop
Description? Tests reports can be empty if there are many errors (investigation in progress).
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? Waiting for CI.

This change is Reviewable

Add a json check
Tests can be empty if there are many errors (investigation in progress)
try:
parsed_data = json.loads(raw_data)
except json.decoder.JSONDecodeError:
# Could not load json file

This comment has been minimized.

@matks

matks Jan 19, 2019

Contributor

Should'nt you store the number of JSON decoding failures somewhere, in order to get the information ?

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 19, 2019

Author Contributor

Not needed because everything is in /tmp directory to prevent useless space usage.

@matks

matks approved these changes Jan 19, 2019

@matks matks merged commit 6bbd9c5 into PrestaShop:develop Jan 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 19, 2019

Thanks @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/nightlies branch Jan 19, 2019

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment