New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ps_viewedproduct in classic theme #12227

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
5 participants
@SharakPL
Copy link
Contributor

SharakPL commented Jan 19, 2019

Questions Answers
Branch? develop
Description? PrestaShop/ps_viewedproduct#7 changed module's template file location from /views/template to /views/templates, but in classic theme it's still /views/template so theme's file had no effect since ps_viewedproduct v1.1.0
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Change content of /themes/classic/modules/ps_viewedproduct/views/template/hook/ps_viewedproduct.tpl to see no effect, because /modules/ps_viewedproduct/views/templates/hook/ps_viewedproduct.tpl is used instead.

This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Jan 19, 2019

Hello @SharakPL!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 22, 2019

Nice catch @SharakPL

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 23, 2019

@PierreRambaud PierreRambaud merged commit 059bb28 into PrestaShop:develop Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 23, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 23, 2019

Thanks @SharakPL

@SharakPL SharakPL deleted the SharakPL:viewedproduct_in_classic_theme branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment