New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SERP: Textarea from tinymce requires jquery to return the text value #12236

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
5 participants
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Jan 21, 2019

Questions Answers
Branch? 1.7.5.x
Description? Partially reverts #11923, as textarea managed by tinymce returns undefined when innerText is called.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #12233
How to test? Add some HTML in the product description. It should not be displayed in the tab SEO of the same product page. When the meta description is empty.

This change is Reviewable

@PierreRambaud PierreRambaud added this to the 1.7.5.1 milestone Jan 21, 2019

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 22, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 9ef8520 into PrestaShop:1.7.5.x Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:serp-text-only branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment