New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing argument in MetaController which caused page crash #12240

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
5 participants
@tomas862
Copy link
Member

tomas862 commented Jan 21, 2019

Questions Answers
Branch? develop
Description? Seems like after the rebase which happened on the weekend page crashed due to small issue.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #12239
How to test? go to page and it will load now without an error

This change is Reviewable

@matks

matks approved these changes Jan 21, 2019

@matks matks added this to In progress in PrestaShop 1.7.6 via automation Jan 21, 2019

@matks matks removed this from In progress in PrestaShop 1.7.6 Jan 21, 2019

@matks matks added this to the 1.7.6.0 milestone Jan 21, 2019

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 22, 2019

@PierreRambaud PierreRambaud merged commit 63f9cb3 into PrestaShop:develop Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 22, 2019

Thanks @tomas862

@tomas862 tomas862 deleted the tomas862:bug-fixes-from-develop/cms-page-not-working branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment