New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore #12243

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Projects
None yet
4 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 21, 2019

Questions Answers
Branch? develop
Description? Cache, download, img, tests/Selenium and admin-dev must ignore everything expect some files to prevent the usage of "git add --force". "log" directory does not exists anymore.
Type? bug fix / improvement / new feature / refacto / critical
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12231
How to test? remove .git directory, git init, git add -A et make sure directories are added.

This change is Reviewable

Update gitignore
Cache, download, img, tests/Selenium and admin-dev must ignore
everything  expect some files to prevent the usage of
"git add --force".
log directory does not exists anymore.
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 21, 2019

Nice! May I ask for adding app/Resources/geoip/GeoLite2-City.mmdb to the gitignore?

@PierreRambaud PierreRambaud added this to the 1.7.6.0 milestone Jan 22, 2019

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 22, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 9c3c192 into PrestaShop:develop Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PierreRambaud PierreRambaud deleted the PierreRambaud:update-gitignore branch Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment