New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate legacy test TermsAndConditionsTest and refactor related class #12249

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
6 participants
@matks
Copy link
Contributor

matks commented Jan 21, 2019

Questions Answers
Branch? develop
Description? Migrate and refactor TermsAndConditionsTest, refactor class TermsAndConditions
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Travis should be green

This change is Reviewable

@matks matks force-pushed the matks:migrate-unit-test-for-terms-and-conds branch from 0edb9c7 to 82fb568 Jan 21, 2019

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 22, 2019

Is this class used somewhere in the project @matks? The QA team could check no feature is impacted by this change.

@matks

This comment has been minimized.

Copy link
Contributor Author

matks commented Jan 22, 2019

It's used in Checkout process (see class ConditionsToApproveFinderCore) to display Terms and Conditions to the customer and get him to approve them using a checkbox.

In theory I have only added phpdoc, renamed variables and moved some code without modifying it. Only https://github.com/PrestaShop/PrestaShop/pull/12249/files#diff-5b1a7682c21540cdf6841600e9cad867R106 is modified significantly because I used sprintf.

Since the unit tests still pass I think I broke nothing ... but who knows 😄 ?

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 22, 2019

@mickaelandrieu mickaelandrieu merged commit fbba52f into PrestaShop:develop Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Jan 23, 2019

Thanks @matks

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment