New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong duration time while combine nightly tests reports #12256

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
3 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 22, 2019

Questions Answers
Branch? develop
Description? Calcul the time by subtract timestamp and convert its to milliseconds.
Use ValueError instead of json.decode.JSONDecodeError
Improve condition check in bash script
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? Travis must be green.

This change is Reviewable

@@ -48,7 +48,7 @@ for test_directory in test/campaigns/full/* ; do
fi
done

if [ "$(ls ${REPORT_PATH})" ]; then
if [ ! -z "$(ls ${REPORT_PATH})" ]; then

This comment has been minimized.

@Quetzacoalt91

Quetzacoalt91 Jan 22, 2019

Member

Why not using -n?

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 22, 2019

Author Contributor

You are right, nice catch 😃

Wrong duration time
Calcul the time by substract timestamp and convert its to
milliseconds.
Use ValueError instead of json.decode.JSONDecodeError
Improve condition check in bash script

@PierreRambaud PierreRambaud force-pushed the PierreRambaud:fix/combine-timestamp branch from 38630f8 to 39b02cb Jan 22, 2019

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 22, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 7ebb37f into PrestaShop:develop Jan 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 22, 2019

THank you @PierreRambaud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment