New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkFile step after downloading a file #12272

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
5 participants
@YosraAk
Copy link
Contributor

YosraAk commented Jan 23, 2019

Questions Answers
Branch? develop
Description? should check that files are well downloaded before verifying any information.
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? TEST_PATH=full/01_orders/* npm run specific-test -- --URL=shopUrl --DIR=DownloadDirectory

This change is Reviewable

@@ -200,8 +200,10 @@ module.exports = {
checkExportedFile: async function (client) {
await client.downloadCart(ShoppingCart.export_carts_button);
await client.checkFile(global.downloadsFolderPath, global.exportCartFileName);
await client.readFile(global.downloadsFolderPath, global.exportCartFileName, 1000);
await client.checkExportedFileInfo(1000);
if (existingFile) {

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 23, 2019

Contributor

use global.existingFile instead

This comment has been minimized.

@YosraAk

YosraAk Jan 23, 2019

Author Contributor

Hi @PierreRambaud,
yes, it's the same, the existingFile here calls the global.existingFile parameter.

Thanks!

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 23, 2019

Contributor

it is not really the same thing since you can have a scoping variable named existingFile :/ with global, you are sure it will always call the good one :)

This comment has been minimized.

@YosraAk

YosraAk Jan 23, 2019

Author Contributor

yes if we will add a scoping parameter with the same name existingFile, it will not take the global existingFile value for sure.

I will fix it so :) .

Thank you!

@mbadrani mbadrani added this to the 1.7.6.0 milestone Jan 23, 2019

@mbadrani
Copy link
Contributor

mbadrani left a comment

Thank you @YosraAk

@mbadrani mbadrani merged commit 3fe4ba9 into PrestaShop:develop Jan 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment