New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zip module test #12281

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
6 participants
@YosraAk
Copy link
Contributor

YosraAk commented Jan 24, 2019

Questions Answers
Branch? develop
Description? Update install module by zip folder test
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? /
How to test? TEST_PATH=full/10_module/1_Zip_module npm run specific-test -- --URL=shopUrl

This change is Reviewable

@YosraAk YosraAk changed the title TE: update zip module test Update zip module test Jan 24, 2019

@khouloudbelguith khouloudbelguith added the TE label Jan 24, 2019

@@ -200,7 +200,7 @@ module.exports = {
checkExportedFile: async function (client) {
await client.downloadCart(ShoppingCart.export_carts_button);
await client.checkFile(global.downloadsFolderPath, global.exportCartFileName);
if (existingFile) {
if (global.existingFile) {

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 24, 2019

Contributor

Can you do it for all occurrences?

This comment has been minimized.

@YosraAk

YosraAk Jan 24, 2019

Author Contributor

Hi @PierreRambaud,

Ok, i will fix it :) .

Thanks!

@PierreRambaud
Copy link
Contributor

PierreRambaud left a comment

existingFile => global.existingFile :)

Thanks ;)

@mbadrani mbadrani added this to the 1.7.6.0 milestone Jan 24, 2019

@mbadrani
Copy link
Contributor

mbadrani left a comment

@ansar21mallouli you can rebase your PR

@mbadrani mbadrani merged commit c31263c into PrestaShop:develop Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ansar21mallouli

This comment has been minimized.

Copy link
Contributor

ansar21mallouli commented Jan 24, 2019

@mbadrani done
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment