New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arabic numbers in link rewrite #12292

Merged
merged 1 commit into from Jan 25, 2019

Conversation

Projects
None yet
5 participants
@PierreRambaud
Copy link
Contributor

PierreRambaud commented Jan 24, 2019

Questions Answers
Branch? 1.7.5.x
Description? Allow arabic numbers in link rewrite.
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12142
How to test? Follow ticket instruction.

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 24, 2019

I approved the PR. However, do we really deal with a regression from PS 1.7.5.0?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor Author

PierreRambaud commented Jan 24, 2019

@Quetzacoalt91 Not sure, like another issue, it has been added in the 1.7.5.1 kanban.

@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Jan 25, 2019

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Jan 25, 2019

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 25, 2019

According to @khouloudbelguith, this bug was reproduced on PS 1.7.5.0 but not PS 1.7.4.4 so it is indeed a regression.

Merging to 1.7.5.x then, thanks @PierreRambaud !

@matks matks merged commit 1be852b into PrestaShop:1.7.5.x Jan 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@matks matks added this to the 1.7.5.1 milestone Jan 25, 2019

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix/12142 branch Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment