New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to enable/disable attribute name on page title #12327

Merged
merged 6 commits into from Jan 31, 2019

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Jan 28, 2019

Questions Answers
Branch? 1.7.5.x
Description? The 1.7.5 version of PrestaShop included SEO modification and integrated the product attributes in the title (ex: T-shit Colibri Size M Color white) This modification should not be forced but configurable, so we added a section in SEO & Trafic administration to disable/enable this feature (disabled by default).
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #11927
How to test? Go in admin to Shop Parameters > SEO & Urls, then toggle the option "Display attributes in the product meta title" this should change the product title on the front (refresh to update the title).

This change is Reviewable

Add SEO options especially for product attributes in title, the front…
… controller uses this Configuration to render the title
@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 28, 2019

Hi @jolelievre this PR needs at least one more review before adding the label "waiting for QA" thanks

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 28, 2019

Here you go. @jolelievre please apply cs fixer to your PR.

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Jan 28, 2019

@ntiepresta ntiepresta self-assigned this Jan 29, 2019

@jolelievre jolelievre force-pushed the jolelievre:seo-meta-title branch from 3df80bf to bafe780 Jan 29, 2019

@jolelievre jolelievre added this to the 1.7.5.1 milestone Jan 30, 2019

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 30, 2019

@mbadrani mbadrani assigned mbadrani and unassigned ntiepresta Jan 30, 2019

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Jan 31, 2019

@Quetzacoalt91 only waiting for Approvement

@Quetzacoalt91 Quetzacoalt91 merged commit 04a54d7 into PrestaShop:1.7.5.x Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 31, 2019

Thank you @jolelievre

@eternoendless eternoendless changed the title Add SEO options especially for product attributes in title, the front… Add SEO options especially for product attributes in title Feb 12, 2019

@eternoendless eternoendless changed the title Add SEO options especially for product attributes in title Make it possible to enable/disable attribute name on page title Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment