New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use show_price to display price in schema.org tags #12341

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
5 participants
@arnaudschaeffer
Copy link
Contributor

arnaudschaeffer commented Jan 29, 2019

Questions Answers
Branch? develop
Description? If you don't want to show prices in products, for eg. by setting show_price to No or hide prices for Group, it does not hide prices in schema.org tags
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? #11844
How to test? See ticket #11844

This is my first PR to a open source project. I did my best to respect contributing guidelines. Let me know if I missed some things.


This change is Reviewable

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Jan 29, 2019

Hello @arnaudschaeffer!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Jan 29, 2019

Thanks a lot for your contribution. The change are legit!
And you missed nothing since all tests are green 👍

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 31, 2019

Thank you @arnaudschaeffer

@Quetzacoalt91 Quetzacoalt91 merged commit 2c881d0 into PrestaShop:develop Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment