New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation on account creation email error #12344

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
7 participants
@SebBareyre
Copy link
Contributor

SebBareyre commented Jan 29, 2019

Questions Answers
Branch? develop
Description? Fix translation if email is already registered on account creation
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? -
How to test? Try to create an account with an already registered email

This change is Reviewable

Fix translation on account creation email error
Fix translation if email is already registered on account creation

@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Jan 31, 2019

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Jan 31, 2019

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.6.0 milestone Jan 31, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit 9c828d6 into PrestaShop:develop Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Copy link
Member

Quetzacoalt91 commented Jan 31, 2019

Thank you @SebBareyre

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Feb 1, 2019

@SebBareyre it was removed by @MathiasReker in this commit: 5d31dfb#diff-fb40c58222cc1693e8a461a4de4956df

If email is too long, it brokes the display:

capture d ecran_951

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Feb 1, 2019

This PR can break the design. Test your change with "test@testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttest.com"

@MathiasReker

This comment has been minimized.

Copy link
Contributor

MathiasReker commented Feb 1, 2019

Also the email is already displayed in the field. Why would you want to add it into the error msg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment