New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel button on Safari browser #12354

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
6 participants
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Jan 29, 2019

Questions Answers
Branch? 1.7.5.x
Description? Fix the cancel button on the back office legacy forms.
Type? bug fix
Category? BO
BC breaks? Nope
Deprecations? Nope
Fixed ticket? Fixes #12299
How to test? Go to the page "Add a category" with Safari, and try the cancel button on all browsers, including Safari. You must be redirected to the previous page.

This change is Reviewable

@@ -850,7 +850,7 @@
</button>
{/if}
{if isset($show_cancel_button) && $show_cancel_button}
<a href="#" class="btn btn-default" {if $table}id="{$table}_form_cancel_btn"{/if} onclick="window.history.back();">
<a class="btn btn-default" {if $table}id="{$table}_form_cancel_btn"{/if} onclick="javascript:window.history.back();">

This comment has been minimized.

@PierreRambaud

PierreRambaud Jan 29, 2019

Contributor

Woot, safari's working like IE6 :/

@mbadrani mbadrani self-assigned this Jan 31, 2019

@mbadrani

This comment has been minimized.

Copy link
Contributor

mbadrani commented Jan 31, 2019

On safari
image

@mbadrani mbadrani added QA ✔️ and removed waiting for QA labels Jan 31, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit e0769a0 into PrestaShop:1.7.5.x Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Quetzacoalt91 Quetzacoalt91 added this to the 1.7.5.1 milestone Jan 31, 2019

@marionf

This comment has been minimized.

Copy link
Contributor

marionf commented Jan 31, 2019

@mbadrani buttons are not centered on your screenshot
If it's not due to this PR, can you create a new issue ?

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:fix-cancel-button-safari branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment