New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto SearchParameters and SearchParametersResolver for pagination #12361

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
7 participants
@jolelievre
Copy link
Contributor

jolelievre commented Jan 30, 2019

Questions Answers
Branch? 1.7.5.x
Description? There was a bug on pagination for logs, this bug was actually larger than that and concerned all Grids. The SearchParametersResolver did not manage overriding rules properly, so when a request had parameters for pagination the former request with filters was ignored. Now the override rules are as follow: Default -> Saved -> Request
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12338
How to test? Go to Advanced Parameters -> Logs, if you dont have enough stored logs you can perform Product modifications to create more or remove a product (for example). The pagination is supposed to work even when you perform a search or if you changer the order field.

This change is Reviewable

@jolelievre jolelievre changed the title Refacto SearchParameters and SearchParametersResolver to have proper … Refacto SearchParameters and SearchParametersResolver for pagination Jan 30, 2019

@jolelievre jolelievre added this to the 1.7.5.1 milestone Jan 30, 2019

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Jan 31, 2019

well spotted @jolelievre :)

I remember I wanted to add tests for this one so I'm happy to see you have done them!

Refacto SearchParameters and SearchParametersResolver to have proper …
…override rules: Default -> Saved -> Request, and add tests

@jolelievre jolelievre force-pushed the jolelievre:filter-pagination branch from 39f2790 to e9e691a Jan 31, 2019

@ntiepresta ntiepresta assigned ntiepresta and unassigned ntiepresta Jan 31, 2019

@Quetzacoalt91 Quetzacoalt91 merged commit d5a29aa into PrestaShop:1.7.5.x Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@go-sudo

This comment has been minimized.

Copy link

go-sudo commented Feb 20, 2019

Hello
I update my ps to the latest version 1.7.5.1 but still smae error with paginagion
I get this error Failed to load resource: the server responded with a status of 500 ()
https://playstore.ma/index.php?id_category=100&controller=category

any idea please
Informations sur votre serveur
Informations sur votre serveur Linux #1 SMP Fri Feb 1 14:54:57 UTC 2019 x86_64

Version du logiciel serveur : Apache

Version de PHP : 7.2.15

Limite de mémoire : 6056M

Temps maximal d'exécution : 3000

Taille max. pour envoi de fichiers : 70M

Informations
Version de PrestaShop : 1.7.5.1

best regards

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Feb 20, 2019

Hi @go-sudo
If you have a problem, please create an issue ;)
Kind regards

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Feb 20, 2019

Hello @go-sudo,

besides I think your bug is completely unrelated to this PR, as it didn't fix a 500 error but a loss of filters parameters when the page was changed. And you seem to have an error on your front office whereas this PR fixed a bug on the back office.

As @PierreRambaud suggested you should create another issue and give more info, a 500 error doesn't give enough information you need to look at the error in your logs or use the debug mode to have the stack trace and exception message.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment