New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation notices reported by Composer #12369

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@Quetzacoalt91
Copy link
Member

Quetzacoalt91 commented Jan 30, 2019

Questions Answers
Branch? develop
Description? Fix the deprecation notices reported on composer commands.
Type? improvement
Category? TE
BC breaks? Nope
Deprecations? Nope
Fixed ticket? /
How to test? Composer install & update are still working.

Issues fixed:

$ composer install
Deprecation warning: Your package name PrestaShop/PrestaShop is invalid, it should not contain uppercase characters. We suggest using presta-shop/presta-shop instead. Make sure you fix this as Composer 2.0 will error.
Deprecation warning: require.beberlei/DoctrineExtensions is invalid, it should not contain uppercase characters. Please use beberlei/doctrineextensions instead. Make sure you fix this as Composer 2.0 will error.
Deprecation warning: require-dev.mikey179/vfsStream is invalid, it should not contain uppercase characters. Please use mikey179/vfsstream instead. Make sure you fix this as Composer 2.0 will error.
[...]

This change is Reviewable

@matks

matks approved these changes Jan 30, 2019

@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Jan 31, 2019

Doesn't need to be validated by QA team, if something is broken we will see it far before the next release :)

It's on me @marionf

@mickaelandrieu mickaelandrieu merged commit 66cb66f into PrestaShop:develop Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.6.0 milestone Jan 31, 2019

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Jan 31, 2019

@mickaelandrieu Since Composer is case-insensitive for the package names, I think most things will be fine. I'm worried though about:

  • other tools that would be scanning the composer.json and that would consider PrestaShop/PrestaShop different from prestashop/prestashop
  • other tools that would suppose the github repository and the composer project name should be identical

@Quetzacoalt91 Quetzacoalt91 deleted the Quetzacoalt91:composer-deprecation-notices branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment