New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change stock alert z index to be on top of header #12395

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
6 participants
@jolelievre
Copy link
Contributor

jolelievre commented Jan 31, 2019

Questions Answers
Branch? 1.7.5.x
Description? Stock alert box was invisible because it was hidden under the menu header.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12387
How to test? Go to Catalog -> Stocks update a product quantity, the green alert must be visible after request is done.

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.5.1 milestone Jan 31, 2019

@PierreRambaud
Copy link
Contributor

PierreRambaud left a comment

It is really good to see that you are not recompile the world when you change just one line :trollface:

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Jan 31, 2019

I was actually surprised myself!!! 😅

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Feb 1, 2019

Thanks @jolelievre

@matks matks merged commit 860e9ea into PrestaShop:1.7.5.x Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Feb 1, 2019

@jolelievre This is because of the new webpack implementation 😄

@jolelievre

This comment has been minimized.

Copy link
Contributor Author

jolelievre commented Feb 1, 2019

@PierreRambaud it's on the 175 branch so I doubt it! 😛
But nice try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment