Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CO] Bugfix DuplicateProcessor.php for PHP 7.1 and 7.2 #12643

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@Nobodaddy
Copy link
Contributor

Nobodaddy commented Feb 20, 2019

Adapted file for use under PHP 7.1 and 7.2 to avoid a blank page

Questions Answers
Branch? 1.6.1.x
Description? Bugfix for PHP 7.1 and 7.2 to make the SQL Manager work again. to make the SQL Manager work again. Must be applied together with #12642
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? (optional) If this PR fixes an Issue, please write "Fixes #[issue number]" here.
How to test? Please indicate how to best verify that this PR is correct.

This change is Reviewable

[CO] Bugfix DuplicateProcessor.php for PHP 7.1 and 7.2
Adapted file for use under PHP 7.1 and 7.2 to avoid a blank page
@mickaelandrieu

This comment has been minimized.

Copy link
Contributor

mickaelandrieu commented Feb 21, 2019

Hello @Nobodaddy,

how can we validate this pull request, please?

Thanks

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Feb 21, 2019

First of all, thank you for contributing to the PrestaShop project!

As you may already know, normal maintenance support for PrestaShop 1.6 ended in October 2018, which is now in extended maintenance mode until June 30, 2019.

During this period, and in order to ensure the stability of current 1.6 shops, only critical bugs and and security fixes will be accepted in the 1.6.1.x branch. If your contribution applies also to the 1.7 branch, please rebase it into the develop branch so that we may include it into the next 1.7 release.

Thanks for your understanding!

@Nobodaddy

This comment has been minimized.

Copy link
Contributor Author

Nobodaddy commented Feb 21, 2019

@PierreRambaud
Understanding? No!
Thank you for the most insightful remarks. This only allows the conclusion that PrestaShop deliberately does not correct errors in order to force users into a still unfinished and extremely buggy version 1.7.
I will certainly not make any further attempt to improve PrestaShop, at least not publicly. I'm done with it!
And let's be honest, who really is interested in 1.7 at all? I mean, apart from the unsuspecting shop owners who seriously think that the latest version of PrestaShop is always the best!

Merci beaucoup pour ces remarques très révélatrices. Ceci conduit seulement à la conclusion que PrestaShop délibérément ne corrige aucune erreur afin de forcer les utilisateurs à utiliser une version 1.7 inachevée et très buggy.
Je n'essaierai certainement pas d'améliorer davantage PrestaShop, du moins pas publiquement. J'en ai fini avec tout ça !
Et soyons réalistes, qui se soucie de la version 1.7 en ce moment ? Je veux dire, à part les marchands sans méfiance qui pensent sérieusement que la dernière version de PrestaShop est toujours la meilleure !

@Nobodaddy Nobodaddy deleted the Nobodaddy:patch-87 branch Feb 21, 2019

@ttoine

This comment has been minimized.

Copy link
Contributor

ttoine commented Feb 21, 2019

Hello,

It is up to you to dislike Prestashop 1.7. However, there are a lot of merchants, agencies, freelancers and developers who really like it now and give great feedback since v1.7.4 and v1.7.5.
Your comment does not respect those people.

We understand that this can be very frustrating to see that your pull request is not critical and will not be merged in the 1.6.1.x branch.

You complain in your comment that 1.7 is "unfinished and buggy. Your help is welcome and will be appreciated to finish it and debug it 😀

@Nobodaddy

This comment has been minimized.

Copy link
Contributor Author

Nobodaddy commented Feb 21, 2019

We understand that this can be very frustrating to see that your pull request is not critical and will not be merged in the 1.6.1.x branch.
C'mon, you and I know that this is totally bs. I posted these changes in the forum before I made this request here. Statements like this only deepen the gap between many users and a small group of developers in their self-sufficient existence in their ivory tower. I'm sorry , Antoine, but such an ignorant reaction is hardly the right way to help to regain the trust lost in recent years. Some shop owners have invested a lot of money and time in their 1.6 shop, too much to be nonchalantly dictated, they should forget that and jump on a new train. This is no gaming area, this is the real world!

@ttoine

This comment has been minimized.

Copy link
Contributor

ttoine commented Feb 22, 2019

I think that you missed an important point: it's not the developers' choice in their ivory tower.

The PrestaShop company is currently investing all its energy to finish the 1.7 and regain the trust from the community. For this reason, the 1.6 is now fixed only in case of critical bug, as explained on the blog last fall. And that is also what Pierre told in his answer.

You really like the 1.6, ok, but its code is hard to maintain, not well tested, and part of the code is becoming obsolete. The result is that when you fix A, most of the time, that changes something in B or C.

That is why we are in a hurry to finish the 1.7. We are listening to feedback from many people, in order to do things well and in the best order.
Please take the time to read the very good article about the project architecture on Build:
http://build.prestashop.com/news/prestashop-in-2019-and-beyond-part-1-current-architecture/

And remember: you don't need to know symfony and composer to use the 1.7: it supports legacy. The database structure is the same. The API is the same. And it's more easy to build a theme. That's how many agencies and module vendors work with it. And they do it with success.

Now, think about Drupal 7 and 8. Same move to symfony, but without legacy support. If you want to upgrade, you must rebuild your website. No module, no theme, ... Well yes, they finished Drupal 8 faster, but what a break... With Prestashop, the change takes more time, it's true. But with the 1.7.5, it's becoming good and merchants are migrating with ease.

This is the real world too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.