Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[*] FO : Added option to display lowest available price, based on product... #1280

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
Contributor

PhpMadman commented Jan 22, 2014

... quantity discounts

IceEyz commented Jan 29, 2014

Very interesting. I suppose this could be easily expanded to including combination prices. This would need to be rewritten to use the getSpecificPrice() function.

Contributor

PhpMadman commented Jan 31, 2014

Yes. I think it can.
Just need to foreach the product attributes.
And would also need to add a check to see if attribute price is higher then default price.
And also, need display what combination is the low and high price.

Contributor

PhpMadman commented Jan 31, 2014

And also probably then also need to add what qty has the lowest price. Since the lowest price can be specific to only one combination with one qty discount

Contributor

PhpMadman commented Aug 28, 2014

Fixed merge conflicts...

Contributor

vTerenti commented Nov 5, 2015

(note: this is an automated message, but answering it will reach a real human )

Hi! Thank you for your pull request: your contribution to PrestaShop means a lot to us!

We are aware that this PR is still open after all this time, and we want to make sure that your hard work is not forgotten.

We are diving back into pull requests, and we want to work with you in order to get your PR to completion: we need your feedback!

Could you read this article from the Build devblog, and take the time to review your pull requests, so that we can work with up-to-date information? You don't have to do it all right now, and every little step helps.

Again, thank you very much for this contribution, and for your renewed feedback on it!

Contributor

PhpMadman commented Nov 6, 2015

Still a good idea to implement, needs to be rewritten to PSR-2.
Will do when I get the time.

And will change branch to develop then.

Contributor

xBorderie commented Nov 9, 2015

Quite a bit of work here too!

And, indeed, it needs to use PSR-2 and be on the develop branch. If you are up to the challenge, that would be great!

Thank you!

Contributor

PhpMadman commented Nov 9, 2015

Remade in #4430

@PhpMadman PhpMadman closed this Nov 9, 2015

@PhpMadman PhpMadman deleted the PhpMadman:1.6-PriceLowHigh branch Nov 9, 2015

Contributor

xBorderie commented Nov 10, 2015

Thank you @PhpMadman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment