Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing lang entries in Configuration #13108

Merged
merged 1 commit into from Apr 4, 2019

Conversation

@rblaurin
Copy link
Contributor

commented Mar 29, 2019

Questions Answers
Branch? develop
Description? Fixes problem caused by missing entries in ps_configuration_lang for some configuration keys as described by @Matt75 in #12962
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #12962
How to test? See more info in the ticket fixed by this PR

This change is Reviewable

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@Matt75 do you have some time to give for reviewing this PR by any chance?

@Matt75

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

@Quetzacoalt91 tested on instance with same configuration described in the issue, it’s works.

@marionf marionf added QA ✔️ and removed waiting for QA labels Apr 4, 2019

@marionf marionf modified the milestones: 1.7.7.0, 1.7.6.0 Apr 4, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

Hi @rblaurin, congratulations your PR has been validated by QA 😄 but unfortunately it has now git conflicts. Can you rebase it ?

EDIT: done by eternoendless 😄

@rblaurin rblaurin dismissed stale reviews from PierreRambaud and Quetzacoalt91 via 6f80b9c Apr 4, 2019

@eternoendless eternoendless force-pushed the rblaurin:patch-4 branch from 6f80b9c to 3301270 Apr 4, 2019

@eternoendless
Copy link
Member

left a comment

Rebased

@eternoendless eternoendless changed the title [BO] Problem with missing lang entries in Configuration Fix missing lang entries in Configuration Apr 4, 2019

@eternoendless

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Thank you @rblaurin

@eternoendless eternoendless merged commit 2447052 into PrestaShop:develop Apr 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.