Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input type for specific price reduction #13382

Merged
merged 2 commits into from Jun 6, 2019

Conversation

@YeLnatSs
Copy link
Contributor

commented Apr 12, 2019

Questions Answers
Branch? develop
Description? Change input type
Type? bug fix
Category? BO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
Fixed ticket? Fixes #12800
How to test? Go on product page, select pricing tab and click on "specific price" and go to "Apply a discount of" section.

This change is Reviewable

'currency' => $this->currency->iso_code,
'constraints' => [
new Assert\Type(['type' => 'numeric']),
],

This comment has been minimized.

Copy link
@Quetzacoalt91

Quetzacoalt91 May 1, 2019

Member

I wonder if this code is redundant with the NumberType behavior.

This comment has been minimized.

Copy link
@YeLnatSs

YeLnatSs May 2, 2019

Author Contributor

I will remove this code.

@YeLnatSs YeLnatSs requested a review from PrestaShop/prestashop-core-developers as a code owner May 2, 2019

@marionf marionf added QA ✔️ and removed waiting for QA labels May 28, 2019

@marionf marionf added this to the 1.7.7.0 milestone May 28, 2019

@PierreRambaud PierreRambaud force-pushed the YeLnatSs:specific-price branch from 6379847 to 275a4b7 Jun 6, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

PR rebased, waiting for Ci

@PierreRambaud PierreRambaud merged commit 022056d into PrestaShop:develop Jun 6, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Thanks @YeLnatSs and sorry for the delay 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.