Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change checkout behaviour #13440

Merged
merged 1 commit into from Apr 30, 2019
Merged

Conversation

@jolelievre
Copy link
Contributor

jolelievre commented Apr 16, 2019

Questions Answers
Branch? 1.7.6.x
Description? Change checkout behavior, next steps are not accessible any more, and continue button must be clicked each time
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13126
How to test? ~

This change is Reviewable

@jolelievre jolelievre added this to the 1.7.6.0 milestone Apr 16, 2019
@jolelievre jolelievre changed the title WIP: Change checkout behaviour (needs to be validated after meeting) Change checkout behaviour (needs to be validated after meeting) Apr 24, 2019
…d contonue button must be clicked each time
@jolelievre jolelievre force-pushed the jolelievre:checkout-behaviour branch from 0cd5a3d to b42ffd1 Apr 30, 2019
@jolelievre jolelievre requested a review from PrestaShop/prestashop-core-developers as a code owner Apr 30, 2019
@marionf marionf self-assigned this Apr 30, 2019
@marionf marionf added QA ✔️ and removed waiting for QA labels Apr 30, 2019
Copy link
Contributor Author

jolelievre left a comment

Reviewable status: 0 of 7 files reviewed, 2 unresolved discussions (waiting on @marionf and @PierreRambaud)


themes/_core/js/checkout.js, line 54 at r1 (raw file):

Previously, PierreRambaud (GoT) wrote…
        const $nextSteps = $clickedStep.nextAll();

Done.

@Quetzacoalt91 Quetzacoalt91 merged commit bcd847e into PrestaShop:1.7.6.x Apr 30, 2019
2 of 3 checks passed
2 of 3 checks passed
code-review/reviewable 7 files, 2 discussions left (marionf, PierreRambaud)
Details
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jolelievre jolelievre deleted the jolelievre:checkout-behaviour branch Jul 12, 2019
</form>

</div>

This comment has been minimized.

Copy link
@rdy4ever

rdy4ever Jul 24, 2019

Contributor

One little BC problem here: when using a theme that doesn't include this button, as a logged-in user, (from add-ons or other custom theme), if the user clicks on step one from another step (after step 1 is completed), then there's no way for him to go back (or forward, te be exact) to the next step, as this button is missing and he cannot click on the other steps. So he gets stuck and needs to refresh the page.

@eternoendless eternoendless changed the title Change checkout behaviour (needs to be validated after meeting) Change checkout behaviour Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.