Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding zones for: Austria, Switzerland, Denkmark, Netherlands, Thaila… #13636

Merged
merged 6 commits into from Oct 18, 2019

Conversation

@manfield
Copy link
Contributor

manfield commented May 2, 2019

Adding zones for: Austria, Switzerland, Denkmark, Netherlands, Thailand (the last one mandatory for Paypal Payments API)

Questions Answers
Branch? develop
Description? Added missing states for some countries
Type? improvement
Category? CO
BC breaks? Does it break backward compatibility? no
Deprecations? Does it deprecate an existing feature? no
How to test? Just import localization package from these conf file

This change is Reviewable

…nd (the last one mandatory for Paypal Payments API)
@manfield manfield requested a review from PrestaShop/prestashop-core-developers as a code owner May 2, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Sep 27, 2019

@manfield Hi. Thank you for your contribution. Please, could you revert your changes on the indentation ? Thanks.

This reverts commit 2f7b1ce.
localization/at.xml Outdated Show resolved Hide resolved
localization/dk.xml Outdated Show resolved Hide resolved
localization/nl.xml Outdated Show resolved Hide resolved
@Progi1984

This comment has been minimized.

Copy link
Contributor

Progi1984 commented Sep 30, 2019

@LouiseBonnard I need your review for this PR. Thanks :)

@manfield

This comment has been minimized.

Copy link
Contributor Author

manfield commented Sep 30, 2019

Sorry for indentation issues.

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Sep 30, 2019

Hello, it seems alright to me, although I'm not certain about the double names regarding the Suiss states. Wouldn't it be better to write German-speaking states in German and French-speaking states in French?

Also, I'll send this PR to the translating community so that we can double-check it with native people from those countries. :-)

PS: note that there are also Australian states but there are not mentioned in the PR description

@bulldesign

This comment has been minimized.

Copy link

bulldesign commented Sep 30, 2019

The Danish zones/regions are correct 👍

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

LouiseBonnard commented Sep 30, 2019

I got a feedback from a Danish translator who said Denmark uses the International System of Units so units should be:

<units> <unit type="weight" value="kg"/> <unit type="volume" value="L"/> <unit type="short_distance" value="cm"/> <unit type="base_distance" value="m"/> <unit type="long_distance" value="km"/> </units>

And this has been confirmed by Marilou here at PrestaShop. ;-)

@mark-app

This comment has been minimized.

Copy link

mark-app commented Sep 30, 2019

For NL

More changes: The low tax is changed on 01-01-2019 from 6% to 9%.

Line 11:

Change to:

Line 68:

Change to:

line 97:

Change to:

Line 126:

Change to:

States should be:

Fixed lowest taxes rate for Netherlands.
localization/au.xml Outdated Show resolved Hide resolved
@Robin-Fischer-PS

This comment has been minimized.

Copy link

Robin-Fischer-PS commented Oct 18, 2019

Hello,

It's okay for me, QA approved 😉

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Oct 18, 2019
@PierreRambaud PierreRambaud merged commit 4757e57 into PrestaShop:develop Oct 18, 2019
2 checks passed
2 checks passed
PrettyCI Code formatting
Details
Travis CI - Pull Request Build Passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

PierreRambaud commented Oct 18, 2019

Thanks @manfield and everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.