Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Specific Price : wrong display #13730

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@123monsite-regis
Copy link
Contributor

commented May 9, 2019

Questions Answers
Branch? develop
Description? The comparaison $price == Tools::ps_round($product->price, 2) is Only valid When currencies are the same, so i'ts better to always show real product selling price
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Use more than one currency , set a specific price for a currency , equal to "normal" product price , but in other currency

When displaying informations about specific product Price, "--" was displayed
on my samples picture : default Currency is € and i set a specific price on USD) , please find below the Specific price configured :
image

Before, this patch , admin Product page ( Pricing Tab ) is :

image

Whereas it should be , as $40 is not Equals to 40 €
image


This change is Reviewable

@123monsite-regis 123monsite-regis requested a review from PrestaShop/prestashop-core-developers as a code owner May 9, 2019

@marionf marionf self-assigned this Jul 24, 2019

@marionf

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Hello @123monsite-regis

I am not sure to well understand what is the issue here, could you please add all the stpes to reproduce the issue ?

@123monsite-regis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

this issue is just a display issue on the Specific Prices List on Admin Product page,

To reproduce it

  • install a Presashop whith at less 2 currencies, on the steps bellow , i use € and $

  • set the defaut currency to €

  • go on an admin product page, Pricing Tab :
    image

  • create a specific price : For Currency dollar $ only , as a fixed price equal to the "normal price whtithout reduction but in €" € price (40 on the sreen below)
    image

  • then on the list of specific prices , you see "--" instead of the Specific $ price
    whithout the correction the dispay is :
    image

After the list is more clear for merchants (40$ is correctly displayed ):
image

Regards

@marionf

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@123monsite-regis

I tried to reproduce the issue on PS 1.7.6.0 but it's well working, please see the screenrecord below:
https://drive.google.com/file/d/1d1xVWHYA3-5a0Z5uoa9--MX3WXwOzfm7/view?usp=sharing

@123monsite-regis

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

hi @marionf

on your record, you need to set the Specific pric to 29 instead of 40 to reproduce this issue.

Regards

@marionf

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Thanks for explanations @123monsite-regis
Indeed, your fix seems legit 👍
Let's wait for code review & QA now

@marionf marionf removed their assignment Jul 29, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 31, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 31, 2019

@PierreRambaud PierreRambaud merged commit e762a65 into PrestaShop:develop Jul 31, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.