Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate var in cart.php #13830

Merged
merged 1 commit into from Jul 31, 2019

Conversation

@davidglezz
Copy link
Contributor

commented May 17, 2019

Questions Answers
Branch? develop
Description? Remove duplicate var with same method call in cart.php
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
How to test? Run test for getPackageShippingCost() in cart.php class

Avoid duplicate call to getOrderTotal() because $total_package_without_shipping_tax_inc === $order_total

$order_total = $this->getOrderTotal(true, Cart::BOTH_WITHOUT_SHIPPING, $product_list);
// ...
$total_package_without_shipping_tax_inc = $this->getOrderTotal(true, Cart::BOTH_WITHOUT_SHIPPING, $product_list);

This change is Reviewable

Remove duplicate var in cart.php
Avoid duplicate call to getOrderTotal()

$total_package_without_shipping_tax_inc === $order_total

@davidglezz davidglezz requested a review from PrestaShop/prestashop-core-developers as a code owner May 17, 2019

@sarahdib

This comment has been minimized.

Copy link

commented Jul 31, 2019

@davidglezz
Thank you for your contribution.

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 31, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 31, 2019

@PierreRambaud PierreRambaud merged commit 6d865d9 into PrestaShop:develop Jul 31, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

Thanks @davidglezz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.