Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLDR data to 35.1 #13906

Merged
merged 6 commits into from Jul 26, 2019

Conversation

@eternoendless
Copy link
Member

commented May 21, 2019

Questions Answers
Branch? develop
Description? Update CLDR specification data to latest release 35.1
Type? improvement
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Amounts should be displayed correctly throughout PrestaShop

This change is Reviewable

@eternoendless eternoendless added this to the 1.7.7.0 milestone May 21, 2019

@eternoendless eternoendless requested a review from PrestaShop/prestashop-core-developers as a code owner May 21, 2019

@tomlev

This comment has been minimized.

Copy link
Member

commented May 22, 2019

we need to figure out what data changed and breaks the tests...
it seems to be related to numbering system and whitespaces.

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Jun 3, 2019

Fixed tests backported to 1.7.6.x: #14060

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

1) LegacyTests\Integration\Core\Localization\LocaleUsageTest::testItShouldFormatNumbers with data set "France" ('fr-FR', 1234568.1234500001, '1 234 568,123')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-1 234 568,123
+1 234 568,123

One more test to fix!

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

What is the status of this PR ?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

PR updated. Waiting for CI.

@PierreRambaud PierreRambaud force-pushed the eternoendless:update-cldr-35.1 branch from 01725a8 to e9897a3 Jul 18, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

Unit tests are now ok!

@eternoendless

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2019

LGTM, I can't approve because it's my own PR :)

@PierreRambaud PierreRambaud merged commit ea3183d into PrestaShop:develop Jul 26, 2019

2 of 3 checks passed

code-review/reviewable 765 files, 1 discussion left (eternoendless)
Details
PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.