New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing and moving tests design from broken to suite full #13953
Fixing and moving tests design from broken to suite full #13953
Conversation
tests/E2E/test/campaigns/full/15_design/3_link_widget/01_linkWidget.js
Outdated
Show resolved
Hide resolved
if(global.isVisible) | ||
client.scrollWaitForExistAndClick(LinkWidget.select_all_static_content.replace('%POS',i)); | ||
i++; | ||
}while(global.isVisible); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this content is a duplicate from tests/E2E/test/campaigns/common_scenarios/linkwidget.js
. To make future changes easier to apply, could you please refacto your code to have a single method containing these lines and then called by your linkwidget
scenarios?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggestion, it's done
Tested in docker context => no errors |
Every detail helps: versions, browser/server configuration, specific module/theme, etc.
- TEST_PATH=full/15_design/3_link_widget/* npm run specific-test -- --URL=shop_URL
This change is