Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing and moving tests design from broken to suite full #13953

Merged

Conversation

boubkerbribri
Copy link
Contributor

@boubkerbribri boubkerbribri commented May 24, 2019

Questions Answers
Branch? 1.7.6.x
Description? Please be specific when describing the PR.
Every detail helps: versions, browser/server configuration, specific module/theme, etc.
Type? refacto
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket? no
How to test? - TEST_PATH=full/15_design/2_pages/* npm run specific-test -- --URL=shop_URL
- TEST_PATH=full/15_design/3_link_widget/* npm run specific-test -- --URL=shop_URL

This change is Reviewable

@boubkerbribri boubkerbribri added the TE Category: Tests label May 24, 2019
@boubkerbribri boubkerbribri added this to the 1.7.6.0 milestone May 24, 2019
@boubkerbribri boubkerbribri requested a review from a team as a code owner May 24, 2019 07:37
@boubkerbribri boubkerbribri added this to In progress in PrestaShop 1.7.6 via automation May 24, 2019
@prestonBot prestonBot added 1.7.6.x Branch Refactoring Type: Refactoring labels May 24, 2019
@colinegin colinegin moved this from In progress to To be reviewed in PrestaShop 1.7.6 May 24, 2019
@boubkerbribri boubkerbribri requested review from matks, Quetzacoalt91 and PierreRambaud and removed request for matks May 24, 2019 08:55
@colinegin colinegin moved this from To be reviewed to To be merged in PrestaShop 1.7.6 May 27, 2019
if(global.isVisible)
client.scrollWaitForExistAndClick(LinkWidget.select_all_static_content.replace('%POS',i));
i++;
}while(global.isVisible);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this content is a duplicate from tests/E2E/test/campaigns/common_scenarios/linkwidget.js. To make future changes easier to apply, could you please refacto your code to have a single method containing these lines and then called by your linkwidget scenarios?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggestion, it's done

@boubkerbribri
Copy link
Contributor Author

Tested in docker context => no errors

@Quetzacoalt91 Quetzacoalt91 merged commit 5aac484 into PrestaShop:1.7.6.x Jun 12, 2019
PrestaShop 1.7.6 automation moved this from To be merged to Done Jun 12, 2019
@boubkerbribri boubkerbribri deleted the brokenTest_CategoryPage branch August 23, 2019 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.6.x Branch Refactoring Type: Refactoring TE Category: Tests
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants