Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute displayAdminLogin hook without shop context #13980

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@idnovate
Copy link
Contributor

commented May 27, 2019

Questions Answers
Branch? develop
Description? Hook is not executed if module is not hooked to displayAdminLogin in store ID 1
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #13962
How to test? Please see issue

This change is Reviewable

@idnovate idnovate requested a review from PrestaShop/prestashop-core-developers as a code owner May 27, 2019

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Since it's the legacy behavior I approve this PR.

@sarahdib sarahdib self-assigned this Jul 15, 2019

@sarahdib

This comment has been minimized.

Copy link

commented Jul 15, 2019

Hello @idnovate

Thank you for your contribution.

I found an error when I clic on transplant a module

image

@idnovate

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@sarahdib I couldn't reproduce the issue in a fresh PS 1.7.6.0 install with the patch applied. Could you give me more information? If you undo the patch the issue is fixed? Are you testing in a multistore?

image

@sarahdib

This comment has been minimized.

Copy link

commented Jul 17, 2019

@idnovate ok I don't understand what's happen before. I can't reproduce the error.

I test again and it's OK.

Thank you

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

We need to re-run PrettyCI, build got lost I think

@PierreRambaud PierreRambaud changed the title BO : Execute displayAdminLogin hook without shop context Execute displayAdminLogin hook without shop context Jul 18, 2019

@PierreRambaud PierreRambaud force-pushed the idnovate:patch-4 branch from df93e09 to f386832 Jul 24, 2019

@PierreRambaud PierreRambaud merged commit 8f21755 into PrestaShop:develop Jul 24, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Thanks @idnovate

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.