Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty tag in webservice XML response #13983

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@pumamood
Copy link
Contributor

commented May 27, 2019

Questions Answers
Branch? develop
Description? Fix empty tag in webservice XML response
Type? bugfix
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? #13981
How to test? See issue

This change is Reviewable

fix for issue #13981
fix for issue #13981

@pumamood pumamood requested a review from PrestaShop/prestashop-core-developers as a code owner May 27, 2019

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

Hello @pumamood!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

Hi!

Your pull request description seems to be incomplete or malformed:

  • The description shouldn't be empty.
  • The type should be one of: new feature, improvement, bug fix, refacto or critical.
  • The category should be one of: FO, BO, CO, IN, TE, WS, LO

Would you mind completing the contribution table ? This would help us understand how interesting your contribution is.

Thank you!

(note: this is an automated message, but answering it will reach a real human )

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Hi and thanks for your pull request.
Could you please complete the description? :)

@matks matks added the waiting for QA label Jul 9, 2019

@matks matks changed the title fix for issue #13981 Fix empty tag in webservice XML response Jul 9, 2019

@matks matks added this to the 1.7.7.0 milestone Jul 9, 2019

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

Hi @pumamood,

It is OK for me.
image

Thanks!

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

Thank you @pumamood

@matks matks merged commit 20a276e into PrestaShop:develop Jul 10, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.