Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Migrate Sell > Catalog > Attributes & Features > Attributes list #14040
@matks, regarding #14040 (comment) (I wasn't allowed to quote reply, idk why
matks left a comment
Ok, but this seems weird now
So it's redundant
I guess we did a mistake but not going from the very beginning for the full array
Can you explain this in a comment ? Because without the explanation, developers will be confused, when they have a single parameter in the route, whether to use the first 2 options or the
sarjon left a comment
Isn't it something we want to avoid, having service without interface?
How about query
How about dedicated query as well?
Previously, matks (Mathieu Ferment) wrote…
Could be related to
Variable name is not clear.
Previously, zuk3975 (Julius Žukauskas) wrote…
Weird, this should be checked why it happens so with include.
@sarjon regarding queries,
When I had dedicated queries, I was suggested to get rid of it and use adapter with object model instead. (#14040 (comment)).
About this: the reason why we do not use Queries in DataProvider for grids is that we introduced CQRS after having built the "how to create a grid" strategy.
So far it's doing OK
I think @mickaelandrieu's plan was to build Grids with neither CQRS nor ObjectModel required, so I guess in the future if we stick to the initial plan, we should replace these Adapters with Doctrine-powered data providers.