Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template vars override in hook actionFrontControllerSetVariables #14049

Merged

Conversation

@Matt75
Copy link
Contributor

commented Jun 2, 2019

Questions Answers
Branch? develop
Description? Allow template vars override in hook actionFrontControllerSetVariables
Type? improvement
Category? FO
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? Please see https://github.com/Matt75/displayshoplogobylang which requires this hook modification to work properly

This change is Reviewable

@Matt75 Matt75 requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 2, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

Does it solve partially needs expressed in #13462 or #11125 ?

@Matt75

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

#13462 is related to Twig, this is for FO who still use Smarty so I don’t think.

#11125 is related to Presenters, here it’s about template vars in FrontController class. I think it’s better to add another hook for Presenters. Maybe I will need it for wishlist module ?

But seems to be similar needs.

@matks

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Note: after merge, needs to be added to hook list on devdocs

As it is a FO hook, it does not need to be added to hook.xml nor in the SQL upgrade, does it ? 🤔

@PierreRambaud PierreRambaud added this to the 1.7.7.0 milestone Jun 14, 2019

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jun 27, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Thank you @Matt75

@matks matks merged commit 2dfb42b into PrestaShop:develop Jul 2, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

Note: after merge, needs to be added to hook list on devdocs

As it is a FO hook, it does not need to be added to hook.xml nor in the SQL upgrade, does it ? 🤔

ping @Quetzacoalt91 @PierreRambaud
Do we need to update hook.xml and SQL upgrade for FO (= legacy) hooks, or is it only for Symfony hooks ?

@Quetzacoalt91

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

You may want to add it into the file hook.xml if you want to provide details about this hook. That's not a mandatory step though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.