Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrates Shopping Carts view page #14065

Merged
merged 29 commits into from Jul 25, 2019

Conversation

@sarjon
Copy link
Member

commented Jun 4, 2019

Questions Answers
Branch? develop
Description? Migrates Shopping Carts view page
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
Fixed ticket? #13879
How to test? Behavior of page should be the same. You can access new page admin-dev/index.php/sell/orders/carts/1/view where 1 can be replaced with any cart ID.

This change is Reviewable

@sarjon sarjon requested a review from PrestaShop/prestashop-core-developers as a code owner Jun 4, 2019

@sarjon

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

@sarahdib fixed!

@sarahdib

This comment has been minimized.

Copy link

commented Jul 18, 2019

@sarjon Thanks I'm waiting for @matks review :)

@colinegin colinegin referenced this pull request Jul 18, 2019

Open

Migrate "Orders > Shopping Carts > View" page #13879

1 of 27 tasks complete
@sarahdib

This comment has been minimized.

Copy link

commented Jul 23, 2019

hello @sarjon
The problem with the tax display is still there :
image
image

The problem appear when I create a cart from the front office. It's ok with the demo cart

@sarjon

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2019

@sarahdib I cannot reproduce it. :/ Is it clean PS installation? Did you set any other settings regarding taxes?

I've tried to fix it, but not sure if that will do the job, as I cannot reproduce it locally. :/ Can you check it now?

@sarahdib

This comment has been minimized.

Copy link

commented Jul 23, 2019

@sarjon

Thank you for the fix it's working now. waiting for @matks review to validate :)

@matks

matks approved these changes Jul 24, 2019

@sarjon

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

@sarahdib QA approved? 🙏

@sarahdib sarahdib added QA ✔️ and removed waiting for QA labels Jul 25, 2019

@sarahdib sarahdib added this to the 1.7.7.0 milestone Jul 25, 2019

@sarahdib

This comment has been minimized.

Copy link

commented Jul 25, 2019

@sarjon yes QA approved

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Thank you @sarjon and @sarahdib

@matks matks merged commit 42ce01c into PrestaShop:develop Jul 25, 2019

2 checks passed

PrettyCI Code formatting
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sarjon sarjon deleted the sarjon:m/carts/view branch Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.