Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add Commands/Queries Profiler tab #14198
I'm wondering who is the real user/use case of introducing this?
Don't expect PrestaShop developers to expect what is CQRS and/or to figure out what/why this information is displayed in the debug toolbar...
As we have the related hooks for each command/query, for an integrator this tab has no value (in its current state), but we could keep the application (ie the page "Command/Query) in the web profiler if it helps the core team and the Symfony developers who want to play with PrestaShop using the "CQRS way" ?
Think about it: the debug toolbar is not infinite so we need to care a lot about what information should be available for the PrestaShop developers.
For example, I think we should also remove the one about Guzzle as no ones really figure out what it does and no one really cares in the community.
This is a dev tool for PS developers, sooner or later they will have to start using it I think (and from trainings I see a very big interest in CQRS from PS devs). There is already a documentation about CQRS (not so complete, but still). Either way, it should not harm anyone having this tool around.
There is already a lot of information in toolbar that is not really related to PS nor needed for PS devs. If we see that this tool is not needed (and you can only know by getting feedback from developers), then we can remove it from debug toolbar without any BC break I think.
Agree, as mentioned before, not all information in debug toolbar is now useful and could be removed. Unfortunately, it's not part of this PR to do so.
We'll tell them
Indeed. But since this is a dev-only tool any mistake we do will not critical. Also I'm thinking that maybe we can work around this matter by allowing dev to toggle the features they want to see in the debug bar.
Yep, makes sense.